Kikyou1997 commented on code in PR #23717:
URL: https://github.com/apache/doris/pull/23717#discussion_r1314266071
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/analyzer/UnboundRelation.java:
##########
@@ -44,6 +45,7 @@
*/
public class UnboundRelation extends LogicalRelation implements Unbound {
+ public final TableSample tableSample;
Review Comment:
According to the one who proposed Optional api to Java8, seems we should
almost never wrap a member with Optional, the only scenario use this API is the
return type of a function
https://stackoverflow.com/questions/26327957/should-java-8-getters-return-optional-type/26328555#26328555
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
