Lchangliang commented on code in PR #23561:
URL: https://github.com/apache/doris/pull/23561#discussion_r1314260710
##########
be/src/olap/segment_loader.cpp:
##########
@@ -37,26 +37,22 @@ bool SegmentCache::lookup(const SegmentCache::CacheKey&
key, SegmentCacheHandle*
if (lru_handle == nullptr) {
return false;
}
- handle->init(_cache.get(), lru_handle);
+ handle->push_segment(_cache.get(), lru_handle);
Review Comment:
Not need. The concurrency occurs only at the methods of LRUCache. The
variable `handle` is only used by one thread.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
