xinyiZzz commented on code in PR #23765:
URL: https://github.com/apache/doris/pull/23765#discussion_r1313088825
##########
be/src/runtime/buffer_control_block.cpp:
##########
@@ -129,18 +129,17 @@ Status
BufferControlBlock::add_batch(std::unique_ptr<TFetchDataResult>& result)
if (_waiting_rpc.empty()) {
// Merge result into batch to reduce rpc times
- if (!_batch_queue.empty() &&
- ((_batch_queue.back()->result_batch.rows.size() + num_rows) <
_buffer_limit) &&
+ if (!_mysql_batch_queue.empty() &&
+ ((_mysql_batch_queue.back()->result_batch.rows.size() + num_rows)
< _buffer_limit) &&
!result->eos) {
- std::vector<std::string>& back_rows =
_batch_queue.back()->result_batch.rows;
+ std::vector<std::string>& back_rows =
_mysql_batch_queue.back()->result_batch.rows;
std::vector<std::string>& result_rows = result->result_batch.rows;
back_rows.insert(back_rows.end(),
std::make_move_iterator(result_rows.begin()),
std::make_move_iterator(result_rows.end()));
} else {
- _batch_queue.push_back(std::move(result));
+ _mysql_batch_queue.push_back(std::move(result));
}
_buffer_rows += num_rows;
- _data_arrival.notify_one();
Review Comment:
If add batch the same BufferControlBlock to FE and Arrow Flight at the same
time, such as BE informing FE that data sending is completed, this may be a
problem.
I restore it first and think about it after debugging with FE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
