[GitHub] [doris] XieJiann commented on a diff in pull request #23715: [fix](Nereids) When col stats is Unknow, not expression should return the stats with selectivity of 1

[via GitHub]

XieJiann commented on code in PR #23715:
URL: https://github.com/apache/doris/pull/23715#discussion_r1312634488


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/stats/FilterEstimation.java:
##########
@@ -348,8 +348,16 @@ A not in (1, 2, 3, 100):
         return estimated;
     }
 
+    // Right Now, we just assume the selectivity is 1 when stats is Unknown
+    private Statistics handleUnknownCase(EstimationContext context) {
+        return context.statistics;
+    }
+
     @Override
     public Statistics visitNot(Not not, EstimationContext context) {
+        if (context.statistics.containUnknownChildStats()) {
+            return handleUnknownCase(context);

Review Comment:
   It helps to understand the behavior that the selectivity is 1 when there is 
unknown input. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org