[GitHub] [doris] morrySnow commented on a diff in pull request #23539: [FE](fucntion) add date_floor/ceil in FE function

[via GitHub]

morrySnow commented on code in PR #23539:
URL: https://github.com/apache/doris/pull/23539#discussion_r1311205148


##########
fe/fe-core/src/main/antlr4/org/apache/doris/nereids/DorisParser.g4:
##########
@@ -397,6 +397,18 @@ primaryExpression
                 (INTERVAL unitsAmount=valueExpression  unit=datetimeUnit
                 | unitsAmount=valueExpression)
             RIGHT_PAREN                                                        
                #date_sub
+    | name=DATE_FLOOR
+            LEFT_PAREN
+                timestamp=valueExpression COMMA
+                (INTERVAL unitsAmount=valueExpression  unit=(YEAR | MONTH| 
WEEK | DAY | HOUR | MINUTE | SECOND)

Review Comment:
   ```suggestion
                   (INTERVAL unitsAmount=valueExpression unit=datetimeUnit
   ```



##########
fe/fe-core/src/main/antlr4/org/apache/doris/nereids/DorisParser.g4:
##########
@@ -397,6 +397,18 @@ primaryExpression
                 (INTERVAL unitsAmount=valueExpression  unit=datetimeUnit
                 | unitsAmount=valueExpression)
             RIGHT_PAREN                                                        
                #date_sub
+    | name=DATE_FLOOR
+            LEFT_PAREN
+                timestamp=valueExpression COMMA
+                (INTERVAL unitsAmount=valueExpression  unit=(YEAR | MONTH| 
WEEK | DAY | HOUR | MINUTE | SECOND)
+                | unitsAmount=valueExpression)
+            RIGHT_PAREN                                                        
                #dateFloor 
+    | name=DATE_CEIL
+            LEFT_PAREN
+                timestamp=valueExpression COMMA
+                (INTERVAL unitsAmount=valueExpression  unit=(YEAR | MONTH| 
WEEK | DAY | HOUR | MINUTE | SECOND)

Review Comment:
   ```suggestion
                   (INTERVAL unitsAmount=valueExpression  unit=datetimeUnit
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org