morrySnow commented on code in PR #23613:
URL: https://github.com/apache/doris/pull/23613#discussion_r1309578099
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/FunctionSet.java:
##########
@@ -241,6 +242,11 @@ public Function getFunction(Function desc,
Function.CompareMode mode, boolean is
inferenceFunctions.add(fn);
continue;
}
+ // datev1 function signature can not be normal one
+ if (fn.getFunctionName().getFunction().equalsIgnoreCase("to_date")
+ && Config.disable_datev1 && fn.getReturnType() ==
Type.DATE) {
+ continue;
Review Comment:
i think we should not remove this function signature. we should do cast
datev1 to datev2 when we create table and insert data
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
