yangzhg commented on a change in pull request #4486:
URL: https://github.com/apache/incubator-doris/pull/4486#discussion_r479883259
##########
File path: be/src/olap/schema_change.cpp
##########
@@ -1197,10 +1197,9 @@ OLAPStatus
SchemaChangeWithSorting::process(RowsetReaderSharedPtr rowset_reader,
}
uint64_t filtered_rows = 0;
- if (!_row_block_changer.change_row_block(ref_row_block,
rowset_reader->version().second,
- new_row_block,
&filtered_rows)) {
+ if ((res = _row_block_changer.change_row_block(ref_row_block,
rowset_reader->version().second,
+ new_row_block,
&filtered_rows)) != OLAP_SUCCESS) {
Review comment:
It is better not to assign values in if statements
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
