kangkaisen commented on a change in pull request #4445:
URL: https://github.com/apache/incubator-doris/pull/4445#discussion_r476395080



##########
File path: 
fe/fe-core/src/main/java/org/apache/doris/analysis/BinaryPredicate.java
##########
@@ -307,6 +307,22 @@ private Type getCmpType() {
             return Type.LARGEINT;
         }
 
+        // Try parse varchar to bigint and decide type

Review comment:
       would better add a comment to describe why do we want to convert string 
to bigint. add note this is compatible with Mysql




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to