github-actions[bot] commented on code in PR #23068: URL: https://github.com/apache/doris/pull/23068#discussion_r1295987681
########## be/src/gutil/strings/split_internal.h: ########## @@ -179,6 +178,17 @@ template <typename T> struct IsNotInitializerList<std::initializer_list<T>> {}; #endif // LANG_CXX11 +namespace base { + +// Types small_ and big_ are guaranteed such that sizeof(small_) < +// sizeof(big_) +typedef char small_; Review Comment: warning: use 'using' instead of 'typedef' [modernize-use-using] ```suggestion using small_ = char; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org