kangkaisen commented on a change in pull request #4424:
URL: https://github.com/apache/incubator-doris/pull/4424#discussion_r474634686
##########
File path:
fe/fe-core/src/main/java/org/apache/doris/planner/DistributedPlanner.java
##########
@@ -361,13 +361,17 @@ private PlanFragment createHashJoinFragment(HashJoinNode
node, PlanFragment righ
// side to be partitioned for correctness)
// - and the expected size of the hash tbl doesn't exceed
perNodeMemLimit
// we set partition join as default when broadcast join cost equals
partition join cost
- if (node.getJoinOp() != JoinOperator.RIGHT_OUTER_JOIN
- && node.getJoinOp() != JoinOperator.FULL_OUTER_JOIN
- && (perNodeMemLimit == 0 || Math.round(
- (double) rhsDataSize * PlannerContext.HASH_TBL_SPACE_OVERHEAD)
<= perNodeMemLimit)
- && (node.getInnerRef().isBroadcastJoin() ||
(!node.getInnerRef().isPartitionJoin()
- && isBroadcastCostSmaller(broadcastCost, partitionCost)))) {
- doBroadcast = true;
+ if (node.getJoinOp() != JoinOperator.RIGHT_OUTER_JOIN &&
node.getJoinOp() != JoinOperator.FULL_OUTER_JOIN) {
+ if (node.getInnerRef().isBroadcastJoin()) {
+ // explicitly told
+ doBroadcast = true;
+ } else if ((perNodeMemLimit == 0 ||
+ Math.round((double) rhsDataSize *
PlannerContext.HASH_TBL_SPACE_OVERHEAD) <= perNodeMemLimit)
+ && (!node.getInnerRef().isPartitionJoin() &&
isBroadcastCostSmaller(broadcastCost, partitionCost))) {
Review comment:
Could move `node.getInnerRef().isPartitionJoin()` to first
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
