sduzh commented on a change in pull request #4310: URL: https://github.com/apache/incubator-doris/pull/4310#discussion_r467789499
########## File path: be/src/olap/field.h ########## @@ -55,6 +55,7 @@ class Field { inline int32_t length() const { return _length; } inline size_t field_size() const { return size() + 1; } inline size_t index_size() const { return _index_size; } + inline std::string name() const { return _name; } Review comment: `const std::string& name() const { return _name; }` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org