zhannngchen commented on code in PR #22282:
URL: https://github.com/apache/doris/pull/22282#discussion_r1277252109
##########
be/src/olap/tablet_meta.h:
##########
@@ -302,6 +303,10 @@ class DeleteBitmap {
using Version = uint64_t;
using BitmapKey = std::tuple<RowsetId, SegmentId, Version>;
std::map<BitmapKey, roaring::Roaring> delete_bitmap; // Ordered map
+ constexpr static inline uint32_t INVALID_SEGMENT_ID =
std::numeric_limits<uint32_t>::max();
Review Comment:
use max()-1
##########
be/src/olap/tablet_meta.h:
##########
@@ -302,6 +303,10 @@ class DeleteBitmap {
using Version = uint64_t;
using BitmapKey = std::tuple<RowsetId, SegmentId, Version>;
std::map<BitmapKey, roaring::Roaring> delete_bitmap; // Ordered map
+ constexpr static inline uint32_t INVALID_SEGMENT_ID =
std::numeric_limits<uint32_t>::max();
+ constexpr static inline uint64_t INVALID_VERSION =
std::numeric_limits<uint64_t>::max();
Review Comment:
use 0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
