yiguolei commented on code in PR #22152:
URL: https://github.com/apache/doris/pull/22152#discussion_r1275891134


##########
be/src/exprs/runtime_filter.cpp:
##########
@@ -1477,7 +1476,7 @@ void IRuntimeFilter::init_profile(RuntimeProfile* 
parent_profile) {
         }
         DCHECK(parent_profile != nullptr);
         _name = fmt::format("RuntimeFilter: (id = {}, type = {})", _filter_id,
-                            ::doris::to_string(_runtime_filter_type));

Review Comment:
   这种的不要动,能感受到是全局的,否则容易乱



##########
be/src/exprs/runtime_filter.cpp:
##########
@@ -1477,7 +1476,7 @@ void IRuntimeFilter::init_profile(RuntimeProfile* 
parent_profile) {
         }
         DCHECK(parent_profile != nullptr);
         _name = fmt::format("RuntimeFilter: (id = {}, type = {})", _filter_id,
-                            ::doris::to_string(_runtime_filter_type));

Review Comment:
   这种的不要动,能感受到是全局的,否则容易乱



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to