[GitHub] [doris] Gabriel39 commented on a diff in pull request #22191: [fix](sort) VSortedRunMerger does not return any rows with a large offset value

[via GitHub]

Gabriel39 commented on code in PR #22191:
URL: https://github.com/apache/doris/pull/22191#discussion_r1273193703


##########
be/src/vec/runtime/vsorted_run_merger.cpp:
##########
@@ -165,13 +199,18 @@ Status VSortedRunMerger::get_next(Block* output_block, 
bool* eos) {
     return Status::OK();
 }
 
-void VSortedRunMerger::next_heap(MergeSortCursor& current) {
+bool VSortedRunMerger::next_heap(MergeSortCursor& current) {
     if (!current->isLast()) {
         current->next();
         _priority_queue.push(current);
+    } else if (_pipeline_engine_enabled) {
+        // need to check sender is readable again before the next reading.
+        _pending_cursor = current.impl;

Review Comment:
   ```suggestion
           _priority_queue.push(current);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org