morrySnow commented on code in PR #22184:
URL: https://github.com/apache/doris/pull/22184#discussion_r1272939522
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/InsertIntoTableCommand.java:
##########
@@ -123,6 +125,11 @@ public void run(ConnectContext ctx, StmtExecutor executor)
throws Exception {
ctx.getExecTimeout(),
ctx.getSessionVariable().getSendBatchParallelism(), false,
false);
+ if (((UnboundOlapTableSink) logicalQuery).isPartialUpdate()) {
+ HashSet<String> partialUpdateCols = new HashSet<String>();
+ partialUpdateCols.addAll(((UnboundOlapTableSink)
logicalQuery).getColNames());
+ sink.setPartialUpdateInputColumns(true, partialUpdateCols);
+ }
Review Comment:
u should add `isPartialUpdate` to LogicalOlapTableSink and
PhysicalOlapTableSink. pass `isPartialUpdate` from unboundSink to
LogicalOlapTableSink in `BindInsertTargetTable` pass it from logical to
physical in `LogicalOlapTableSinkToPhysicalOlapTableSink` and
setPartialUpdateInputColumns to `OlapTableSink` in
`org.apache.doris.nereids.glue.translator.PhysicalPlanTranslator#visitPhysicalOlapTableSink`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
