hubgeter commented on code in PR #22115:
URL: https://github.com/apache/doris/pull/22115#discussion_r1271727723
##########
fe/fe-core/src/main/java/org/apache/doris/planner/external/HiveScanNode.java:
##########
@@ -310,4 +299,28 @@ private void genSlotToSchemaIdMap() {
}
params.setSlotNameToSchemaPos(columnNameToPosition);
}
+
+ @Override
+ public boolean pushDownAggNoGrouping(FunctionCallExpr aggExpr) {
+ TFileFormatType fileFormatType;
+ try {
+ fileFormatType = getFileFormatType();
+ } catch (UserException e) {
+ throw new RuntimeException(e);
+ }
+
+ String aggFunctionName = aggExpr.getFnName().getFunction();
+ if (aggFunctionName.equalsIgnoreCase("COUNT") && fileFormatType ==
TFileFormatType.FORMAT_PARQUET) {
+ return true;
+ }
+ return false;
+ }
+
+ @Override
+ public boolean pushDownAggNoGroupingCheckCol(FunctionCallExpr aggExpr,
Column col) {
Review Comment:
when you use `select count(*)`statement ,`pushDownAggNoGroupingCheckCol`
will not be executed .
if you use `select count(a)` statement , `pushDownAggNoGroupingCheckCol`
will check col a.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
