HappenLee commented on code in PR #21940:
URL: https://github.com/apache/doris/pull/21940#discussion_r1271476471


##########
be/src/olap/rowset/beta_rowset_reader.cpp:
##########
@@ -75,9 +75,9 @@ bool BetaRowsetReader::update_profile(RuntimeProfile* 
profile) {
 }
 
 Status BetaRowsetReader::get_segment_iterators(RowsetReaderContext* 
read_context,
+                                               size_t scanner_idx,

Review Comment:
   scanner_idx seems useless in this function? why pass the arg?



##########
be/src/olap/rowset/beta_rowset_reader.cpp:
##########
@@ -75,9 +75,9 @@ bool BetaRowsetReader::update_profile(RuntimeProfile* 
profile) {
 }
 
 Status BetaRowsetReader::get_segment_iterators(RowsetReaderContext* 
read_context,
+                                               size_t scanner_idx,

Review Comment:
   scanner_idx seems useless in this function? why pass the arg?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to