WingsGo commented on a change in pull request #4187:
URL: https://github.com/apache/incubator-doris/pull/4187#discussion_r460532621
##########
File path: fe/fe-core/src/main/java/org/apache/doris/common/util/TimeUtils.java
##########
@@ -256,7 +256,7 @@ public static String
checkTimeZoneValidAndStandardize(String value) throws DdlEx
Matcher matcher = TIMEZONE_OFFSET_FORMAT_REG.matcher(value);
// it supports offset and region timezone type, "CST" use here is
compatibility purposes.
boolean match = matcher.matches();
- if (!value.contains("/") && !value.equals("CST") && !match) {
+ if (!value.contains("/") && !value.equals("CST") &&
!value.equals("UTC") && !match) {
Review comment:
The root case of the problem such as `PRC` Timezone is that TimeUtils
check is only check by regex we given, maybe we should also check the timezone
exists in `ZoneId.getAvailableZoneIds`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
