HappenLee commented on code in PR #21668: URL: https://github.com/apache/doris/pull/21668#discussion_r1257821256
########## be/src/pipeline/pipeline_fragment_context.cpp: ########## @@ -707,6 +707,16 @@ Status PipelineFragmentContext::submit() { } } +void PipelineFragmentContext::close_sink() { + if (_sink) { + if (_prepared) { + _sink->close(_runtime_state.get(), Status::RuntimeError("prepare failed")); + } else { + _sink->close(_runtime_state.get(), Status::OK()); Review Comment: maybe need dispose status of sink close? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org