github-actions[bot] commented on PR #20716:
URL: https://github.com/apache/doris/pull/20716#issuecomment-1627951195
#### `sh-checker report`
To get the full details, please check in the
[job]("https://github.com/apache/doris/actions/runs/5503150130";) output.
<details>
<summary>shellcheck errors</summary>
```
'shellcheck ' returned error 1 finding the following syntactical issues:
----------
In minidump/nereids_ut.sh line 39:
RUN_DAEMON=0
^--------^ SC2034 (warning): RUN_DAEMON appears unused. Verify use (or
export if used externally).
In minidump/nereids_ut.sh line 40:
HELPER=''
^----^ SC2034 (warning): HELPER appears unused. Verify use (or export if
used externally).
In minidump/nereids_ut.sh line 174:
${JAVA}" ${final_java_opt:+${final_java_opt}} -Xmx2g
org.apache.doris.nereids.minidump.Minidump "${dir}"
${OPT_VERSION:+${OPT_VERSION}} "$@" > "${temp_file}
^-----^ SC2086 (info): Double quote to prevent globbing and word
splitting.
^----^ SC2027 (warning): The surrounding quotes
actually unquote this. Remove or escape them.
^----^ SC2086 (info): Double quote to prevent
globbing and word splitting.
^-- SC2068
(error): Double quote array expansions to avoid re-splitting elements.
^-- SC2145
(error): Argument mixes string and array. Use * or separate argument.
^-- SC2027
(warning): The surrounding quotes actually unquote this. Remove or escape them.
^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
"${JAVA}"" ${final_java_opt:+${final_java_opt}} -Xmx2g
org.apache.doris.nereids.minidump.Minidump ""${dir}""
${OPT_VERSION:+${OPT_VERSION}} "$@" > ""${temp_file}"
For more information:
https://www.shellcheck.net/wiki/SC2068 -- Double quote array expansions to
...
https://www.shellcheck.net/wiki/SC2145 -- Argument mixes string and array.
...
https://www.shellcheck.net/wiki/SC2027 -- The surrounding quotes actually
u...
----------
You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
# shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.
```
</details>
<details>
<summary>shfmt errors</summary>
```
'shfmt ' returned error 1 finding the following formatting issues:
----------
--- minidump/nereids_ut.sh.orig
+++ minidump/nereids_ut.sh
@@ -168,14 +168,12 @@
sql_head="|Sql="
for dir in "${DUMP_FILE_DIR}"/*; do
- if [[ -d "${dir}" ]]; then # Check if the path is a directory
- query_id=${dir: -33}
- temp_file=${LOG_DIR}/temp
+ if [[ -d "${dir}" ]]; then # Check if the path is a directory
+ query_id=${dir: -33}
+ temp_file=${LOG_DIR}/temp
${JAVA}" ${final_java_opt:+${final_java_opt}} -Xmx2g
org.apache.doris.nereids.minidump.Minidump "${dir}"
${OPT_VERSION:+${OPT_VERSION}} "$@" > "${temp_file}
- result=$(cat "${temp_file}")
- echo "${query_id_head} ${query_id} ${sql_head} ${result}" |tee >>
"${LOG_DIR}/minidump.out"
+ result=$(cat "${temp_file}")
+ echo "${query_id_head} ${query_id} ${sql_head} ${result}" | tee
>>"${LOG_DIR}/minidump.out"
fi
done
-date >> "${LOG_DIR}/minidump.out"
-
-
+date >>"${LOG_DIR}/minidump.out"
----------
You can reformat the above files to meet shfmt's requirements by typing:
shfmt -w filename
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
