eldenmoon commented on code in PR #21547:
URL: https://github.com/apache/doris/pull/21547#discussion_r1254145741
##########
be/src/olap/memtable_flush_executor.cpp:
##########
@@ -84,7 +92,24 @@ Status FlushToken::wait() {
return s == OK ? Status::OK() : Status::Error(s);
}
-void FlushToken::_flush_memtable(MemTable* memtable, int64_t submit_task_time)
{
+Status FlushToken::_do_flush_memtable(MemTable* memtable, int32_t segment_id,
int64_t* flush_size) {
+ VLOG_CRITICAL << "begin to flush memtable for tablet: " <<
memtable->tablet_id()
+ << ", memsize: " << memtable->memory_usage()
+ << ", rows: " << memtable->stat().raw_rows;
+ int64_t duration_ns;
+ SCOPED_RAW_TIMER(&duration_ns);
+ std::unique_ptr<vectorized::Block> block = memtable->to_block();
+
SKIP_MEMORY_CHECK(RETURN_IF_ERROR(_rowset_writer->unfold_variant_column_and_flush_block(
Review Comment:
I will refactor unfold_variant_column_and_flush_block later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
