amorynan commented on code in PR #21330: URL: https://github.com/apache/doris/pull/21330#discussion_r1250347552
########## be/src/vec/functions/array/function_array_contains_all.cpp: ########## @@ -0,0 +1,189 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include "common/status.h" +#include "vec/columns/column.h" +#include "vec/columns/column_array.h" +#include "vec/columns/column_const.h" +#include "vec/columns/column_nullable.h" +#include "vec/common/assert_cast.h" +#include "vec/core/block.h" +#include "vec/core/column_numbers.h" +#include "vec/core/types.h" +#include "vec/data_types/data_type.h" +#include "vec/data_types/data_type_number.h" +#include "vec/functions/function.h" +#include "vec/functions/simple_function_factory.h" + +namespace doris::vectorized { + +class FunctionArrayContainsAll : public IFunction { +public: + static constexpr auto name {"array_contains_all"}; + + static FunctionPtr create() { return std::make_shared<FunctionArrayContainsAll>(); } + + String get_name() const override { return name; } + + bool is_variadic() const override { return false; } + + bool use_default_implementation_for_nulls() const override { return false; } + + bool use_default_implementation_for_constants() const override { return false; } + + size_t get_number_of_arguments() const override { return 2; } + + DataTypePtr get_return_type_impl(const DataTypes& arguments) const override { + return std::make_shared<DataTypeUInt8>(); + } + + Status execute_impl(FunctionContext* context, Block& block, const ColumnNumbers& arguments, + size_t result, size_t input_rows_count) override { + // perpare the result column. + auto result_col = ColumnUInt8::create(input_rows_count, 0); + + // fetch the input columns. + const auto& left_input_col = block.get_by_position(arguments[0]).column; + const auto& right_input_col = block.get_by_position(arguments[1]).column; + + // remove the constness of the input columns if necessary. + const auto& [left_col_nullable, is_left_const] = unpack_if_const(left_input_col); + const auto& [right_col_nullable, is_right_const] = unpack_if_const(right_input_col); + + // casts the columns in advance to avoid the repeated casting in the for loop. + // we won't access the cells until we're sure that they're not null, + // so it's safe to cast the columns in advance. + const ColumnArray* left_col_array = check_and_get_column<ColumnArray>(left_col_nullable); + const ColumnArray* right_col_array = check_and_get_column<ColumnArray>(right_col_nullable); + + for (size_t i = 0; i < input_rows_count; ++i) { + // FIXME(niebayes): the null checking seems already done in the frontend. + if (left_col_nullable->is_null_at(i) || right_col_nullable->is_null_at(i)) { + continue; + } + + // each array is a cell in a column array. + // however, arrays in a column are flattened to reduce storage overhead. + // therefore, we need to use offsets to delimit among arrays and + // to locate the elements in an array. + const ColumnNullable* left_nested_col_nullable = + check_and_get_column<ColumnNullable>(left_col_array->get_data()); Review Comment: out of loop -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
