wsjz commented on code in PR #21238:
URL: https://github.com/apache/doris/pull/21238#discussion_r1246173988
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/iceberg/HiveCompatibleCatalog.java:
##########
@@ -57,7 +57,7 @@ public void initialize(String name, FileIO fileIO,
protected FileIO initializeFileIO(Map<String, String> properties,
Configuration hadoopConf) {
String fileIOImpl = properties.get(CatalogProperties.FILE_IO_IMPL);
if (fileIOImpl == null) {
- FileIO io = new S3FileIO();
+ FileIO io = new HadoopFileIO(hadoopConf);
Review Comment:
Note: s3 file need some custom configuration, so hadoop io is used in
superclass by default, we can add better implementations to derived class just
like the implementation in dlf catalog.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
