WingsGo commented on pull request #3986: URL: https://github.com/apache/incubator-doris/pull/3986#issuecomment-651743033
> Better to use a `string` instead of `int` type of this config. > And TSimpleServer seems unnecessary. use string is better, but Config have no check logic, we can only set default server model when use have typo error like `Threadd`,In this case, user may think they use a `Threaded` server model, but it is not what he think, use int type is to avoid situation like this. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
