caiconghui commented on a change in pull request #3943:
URL: https://github.com/apache/incubator-doris/pull/3943#discussion_r446590558
##########
File path: be/src/olap/rowset/segment_v2/segment_iterator.cpp
##########
@@ -253,30 +253,37 @@ Status
SegmentIterator::_get_row_ranges_from_conditions(RowRanges* condition_row
_opts.stats->rows_bf_filtered += (pre_size -
condition_row_ranges->count());
RowRanges zone_map_row_ranges = RowRanges::create_single(num_rows());
- std::map<int, std::vector<CondColumn*>> column_delete_conditions;
- // zone map will use delete conditions
- for (auto& delete_condition : _opts.delete_conditions) {
- for (auto& column_condition : delete_condition->columns()) {
- cids.insert(column_condition.first);
- std::vector<CondColumn*>& conditions =
column_delete_conditions[column_condition.first];
- conditions.emplace_back(column_condition.second);
- }
- }
+ // second filter data by zone map
for (auto& cid : cids) {
// get row ranges by zone map of this column,
RowRanges column_row_ranges = RowRanges::create_single(num_rows());
- CondColumn* column_cond = nullptr;
- if (_opts.conditions != nullptr) {
- column_cond = _opts.conditions->get_column(cid);
- }
+ CondColumn* column_cond = _opts.conditions->get_column(cid);
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
