morningman commented on a change in pull request #3947:
URL: https://github.com/apache/incubator-doris/pull/3947#discussion_r446279706
##########
File path: be/src/runtime/datetime_value.cpp
##########
@@ -1535,7 +1521,10 @@ bool DateTimeValue::unix_timestamp(int64_t* timestamp,
const std::string& timezo
if (!find_cctz_time_zone(timezone, ctz)) {
Review comment:
It needs a thread safe cache.
Since there is not much calls of `find_cctz_time_zone()`, I think we can
improve it later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
