yiguolei commented on code in PR #20732:
URL: https://github.com/apache/doris/pull/20732#discussion_r1227967048
##########
be/src/olap/storage_engine.cpp:
##########
@@ -1155,10 +1155,15 @@ Status StorageEngine::execute_task(EngineTask* task) {
}
// check whether any unused rowsets's id equal to rowset_id
-bool StorageEngine::check_rowset_id_in_unused_rowsets(const RowsetId&
rowset_id) {
+std::optional<RowsetSharedPtr> StorageEngine::get_rowset_in_unused_rowsets(
Review Comment:
I think its very bad to get a rowset from gc space. GC is a standalone
service. Other logic should not depend on it. The rowset is already hold in
query context, I think you should get it from query context.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
