csun5285 commented on code in PR #20715:
URL: https://github.com/apache/doris/pull/20715#discussion_r1227899646


##########
be/src/olap/tablet.cpp:
##########
@@ -1062,9 +1063,14 @@ uint32_t Tablet::_calc_base_compaction_score() const {
             // all_rs_metas() is not sorted, so we use _continue_ other than 
_break_ here.
             continue;
         }
-
+        if (rs_meta->has_delete_predicate()) {
+            has_delete = true;
+        }
         score += rs_meta->get_compaction_score();
     }
+    if (config::enable_time_series_compaction_mode) {
+        return base_rowset_exist && has_delete ? score : 0;

Review Comment:
   done



##########
be/src/olap/tablet.cpp:
##########
@@ -1062,9 +1063,14 @@ uint32_t Tablet::_calc_base_compaction_score() const {
             // all_rs_metas() is not sorted, so we use _continue_ other than 
_break_ here.
             continue;
         }
-
+        if (rs_meta->has_delete_predicate()) {
+            has_delete = true;
+        }
         score += rs_meta->get_compaction_score();
     }
+    if (config::enable_time_series_compaction_mode) {

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to