[GitHub] [doris] jackwener commented on a diff in pull request #20310: [minor](Nereids): remove useless withNewChildren()

[via GitHub]

jackwener commented on code in PR #20310:
URL: https://github.com/apache/doris/pull/20310#discussion_r1213907561


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/logical/PushdownFilterThroughSetOperation.java:
##########
@@ -45,11 +45,11 @@ public class PushdownFilterThroughSetOperation extends 
OneRewriteRuleFactory {
 
     @Override
     public Rule build() {
-        return logicalFilter(logicalSetOperation()).then(filter -> {
-            LogicalSetOperation setOperation = filter.child();
+        return logicalFilter(logicalSetOperation()).when(f -> 
f.child().getQualifier() == Qualifier.ALL).then(f -> {

Review Comment:
   
![image](https://github.com/apache/doris/assets/30525741/4228586d-ccac-4eee-8b3a-1d91adaea96e)
   
   original code also didn't handle it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org