imay commented on a change in pull request #3768:
URL: https://github.com/apache/incubator-doris/pull/3768#discussion_r435656472
##########
File path: fe/src/main/java/org/apache/doris/analysis/ColumnDef.java
##########
@@ -131,6 +131,16 @@ public void analyze(boolean isOlap) throws
AnalysisException {
Type type = typeDef.getType();
+ // disable Bitmap Hll type in keys, values without aggregate function.
+ if ( type.isBitmapType() || type.isHllType() ){
+ if (isKey){
Review comment:
```suggestion
if (isKey) {
```
##########
File path: fe/src/main/java/org/apache/doris/analysis/ColumnDef.java
##########
@@ -131,6 +131,16 @@ public void analyze(boolean isOlap) throws
AnalysisException {
Type type = typeDef.getType();
+ // disable Bitmap Hll type in keys, values without aggregate function.
+ if ( type.isBitmapType() || type.isHllType() ){
Review comment:
Should keep code style with original code.
```suggestion
if (type.isBitmapType() || type.isHllType()) {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
