eldenmoon commented on code in PR #19543:
URL: https://github.com/apache/doris/pull/19543#discussion_r1201904187
##########
be/src/vec/data_types/serde/data_type_nullable_serde.cpp:
##########
@@ -131,5 +132,30 @@ void
DataTypeNullableSerDe::read_column_from_arrow(IColumn& column, const arrow:
ctz);
}
+template <bool is_binary_format>
+Status DataTypeNullableSerDe::_write_column_to_mysql(
+ const IColumn& column, std::vector<MysqlRowBuffer<is_binary_format>>&
result, int row_idx,
+ int start, int end, int scale, bool col_const) const {
+ int buf_ret = 0;
+ auto& col = static_cast<const ColumnNullable&>(column);
+ auto& nested_col = col.get_nested_column();
+ for (ssize_t i = start; i < end; ++i) {
+ LOG(WARNING) << "amory: " << start << " : " << end;
+ if (0 != buf_ret) {
+ return Status::InternalError("pack mysql buffer failed.");
+ }
+ const auto col_index = index_check_const(i, col_const);
+ LOG(WARNING) << "amory: " << col_index << " is null: " <<
col.is_null_at(col_index);
+ if (col.is_null_at(col_index)) {
Review Comment:
why not `col.is_null_at(row_idx)`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
