HappenLee commented on code in PR #19847:
URL: https://github.com/apache/doris/pull/19847#discussion_r1198716937
##########
be/src/vec/sink/vdata_stream_sender.h:
##########
@@ -403,9 +423,23 @@ Status VDataStreamSender::channel_add_rows(Channels&
channels, int num_channels,
channel2rows[channel_ids[i]].emplace_back(i);
}
+ Status status;
for (int i = 0; i < num_channels; ++i) {
if (!channel2rows[i].empty()) {
- RETURN_IF_ERROR(channels[i]->add_rows(block, channel2rows[i]));
+ status = channels[i]->add_rows(block, channel2rows[i]);
+ if (status.is<ErrorCode::END_OF_FILE>()) {
+ channels[i]->set_receiver_eof(status);
+ continue;
+ }
+ RETURN_IF_ERROR(status);
+ }
+ }
+ for (auto it = channels.begin(); it != channels.end();) {
+ if ((*it)->receiver_status().template is<ErrorCode::END_OF_FILE>()) {
+ (*it)->close(_state);
+ it = channels.erase(it);
Review Comment:
erase the channel may cause the parttion get error result
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
