morningman commented on code in PR #19544:
URL: https://github.com/apache/doris/pull/19544#discussion_r1193968533


##########
be/src/vec/exec/format/parquet/schema_desc.cpp:
##########
@@ -240,6 +240,15 @@ TypeDescriptor 
FieldDescriptor::convert_to_doris_type(tparquet::LogicalType logi
         type = TypeDescriptor(TYPE_TIMEV2);
     } else if (logicalType.__isset.TIMESTAMP) {
         type = TypeDescriptor(TYPE_DATETIMEV2);
+        const auto& time_unit = logicalType.TIMESTAMP.unit;
+        if (time_unit.__isset.MILLIS) {
+            type.scale = 3;
+        } else if (time_unit.__isset.MICROS) {
+            type.scale = 6;
+        } else if (time_unit.__isset.NANOS) {

Review Comment:
   Do we need a default branch?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to