jackwener commented on code in PR #19288:
URL: https://github.com/apache/doris/pull/19288#discussion_r1185731866
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/jobs/batch/NereidsRewriter.java:
##########
@@ -158,6 +159,11 @@ public class NereidsRewriter extends BatchRewriteJob {
),
topic("Rewrite join",
+ // transform semi join to inner join
+ // TODO: current rule is under special scenario, will put it
into cost based
+ // transformation framework in the future.
+ custom(RuleType.SEMI_TO_INNER, SemiToInner::new),
Review Comment:
Don't mix two feature in one PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
