github-actions[bot] commented on code in PR #19301:
URL: https://github.com/apache/doris/pull/19301#discussion_r1185708175
##########
be/src/common/consts.h:
##########
@@ -21,16 +21,18 @@
namespace doris {
namespace BeConsts {
-const std::string CSV = "csv";
-const std::string CSV_WITH_NAMES = "csv_with_names";
-const std::string CSV_WITH_NAMES_AND_TYPES = "csv_with_names_and_types";
-const std::string BLOCK_TEMP_COLUMN_PREFIX = "__TEMP__";
-const std::string ROWID_COL = "__DORIS_ROWID_COL__";
-const std::string ROW_STORE_COL = "__DORIS_ROW_STORE_COL__";
-const std::string DYNAMIC_COLUMN_NAME = "__DORIS_DYNAMIC_COL__";
+
+inline const std::string CSV = "csv";
Review Comment:
warning: inline variables are a C++17 extension
[clang-diagnostic-c++17-extensions]
```cpp
inline const std::string CSV = "csv";
^
```
##########
be/src/common/consts.h:
##########
@@ -21,16 +21,18 @@
namespace doris {
namespace BeConsts {
-const std::string CSV = "csv";
-const std::string CSV_WITH_NAMES = "csv_with_names";
-const std::string CSV_WITH_NAMES_AND_TYPES = "csv_with_names_and_types";
-const std::string BLOCK_TEMP_COLUMN_PREFIX = "__TEMP__";
-const std::string ROWID_COL = "__DORIS_ROWID_COL__";
-const std::string ROW_STORE_COL = "__DORIS_ROW_STORE_COL__";
-const std::string DYNAMIC_COLUMN_NAME = "__DORIS_DYNAMIC_COL__";
+
+inline const std::string CSV = "csv";
+inline const std::string CSV_WITH_NAMES = "csv_with_names";
+inline const std::string CSV_WITH_NAMES_AND_TYPES = "csv_with_names_and_types";
+inline const std::string BLOCK_TEMP_COLUMN_PREFIX = "__TEMP__";
+inline const std::string ROWID_COL = "__DORIS_ROWID_COL__";
Review Comment:
warning: inline variables are a C++17 extension
[clang-diagnostic-c++17-extensions]
```cpp
inline const std::string ROWID_COL = "__DORIS_ROWID_COL__";
^
```
##########
be/src/common/consts.h:
##########
@@ -21,16 +21,18 @@
namespace doris {
namespace BeConsts {
-const std::string CSV = "csv";
-const std::string CSV_WITH_NAMES = "csv_with_names";
-const std::string CSV_WITH_NAMES_AND_TYPES = "csv_with_names_and_types";
-const std::string BLOCK_TEMP_COLUMN_PREFIX = "__TEMP__";
-const std::string ROWID_COL = "__DORIS_ROWID_COL__";
-const std::string ROW_STORE_COL = "__DORIS_ROW_STORE_COL__";
-const std::string DYNAMIC_COLUMN_NAME = "__DORIS_DYNAMIC_COL__";
+
+inline const std::string CSV = "csv";
+inline const std::string CSV_WITH_NAMES = "csv_with_names";
+inline const std::string CSV_WITH_NAMES_AND_TYPES = "csv_with_names_and_types";
+inline const std::string BLOCK_TEMP_COLUMN_PREFIX = "__TEMP__";
+inline const std::string ROWID_COL = "__DORIS_ROWID_COL__";
+inline const std::string ROW_STORE_COL = "__DORIS_ROW_STORE_COL__";
+inline const std::string DYNAMIC_COLUMN_NAME = "__DORIS_DYNAMIC_COL__";
-constexpr int MAX_DECIMAL32_PRECISION = 9;
-constexpr int MAX_DECIMAL64_PRECISION = 18;
-constexpr int MAX_DECIMAL128_PRECISION = 38;
+inline constexpr int MAX_DECIMAL32_PRECISION = 9;
Review Comment:
warning: inline variables are a C++17 extension
[clang-diagnostic-c++17-extensions]
```cpp
inline constexpr int MAX_DECIMAL32_PRECISION = 9;
^
```
##########
be/src/common/consts.h:
##########
@@ -21,16 +21,18 @@
namespace doris {
namespace BeConsts {
-const std::string CSV = "csv";
-const std::string CSV_WITH_NAMES = "csv_with_names";
-const std::string CSV_WITH_NAMES_AND_TYPES = "csv_with_names_and_types";
-const std::string BLOCK_TEMP_COLUMN_PREFIX = "__TEMP__";
-const std::string ROWID_COL = "__DORIS_ROWID_COL__";
-const std::string ROW_STORE_COL = "__DORIS_ROW_STORE_COL__";
-const std::string DYNAMIC_COLUMN_NAME = "__DORIS_DYNAMIC_COL__";
+
+inline const std::string CSV = "csv";
+inline const std::string CSV_WITH_NAMES = "csv_with_names";
+inline const std::string CSV_WITH_NAMES_AND_TYPES = "csv_with_names_and_types";
Review Comment:
warning: inline variables are a C++17 extension
[clang-diagnostic-c++17-extensions]
```cpp
inline const std::string CSV_WITH_NAMES_AND_TYPES =
"csv_with_names_and_types";
^
```
##########
be/src/common/consts.h:
##########
@@ -21,16 +21,18 @@
namespace doris {
namespace BeConsts {
-const std::string CSV = "csv";
-const std::string CSV_WITH_NAMES = "csv_with_names";
-const std::string CSV_WITH_NAMES_AND_TYPES = "csv_with_names_and_types";
-const std::string BLOCK_TEMP_COLUMN_PREFIX = "__TEMP__";
-const std::string ROWID_COL = "__DORIS_ROWID_COL__";
-const std::string ROW_STORE_COL = "__DORIS_ROW_STORE_COL__";
-const std::string DYNAMIC_COLUMN_NAME = "__DORIS_DYNAMIC_COL__";
+
+inline const std::string CSV = "csv";
+inline const std::string CSV_WITH_NAMES = "csv_with_names";
+inline const std::string CSV_WITH_NAMES_AND_TYPES = "csv_with_names_and_types";
+inline const std::string BLOCK_TEMP_COLUMN_PREFIX = "__TEMP__";
Review Comment:
warning: inline variables are a C++17 extension
[clang-diagnostic-c++17-extensions]
```cpp
inline const std::string BLOCK_TEMP_COLUMN_PREFIX = "__TEMP__";
^
```
##########
be/src/common/consts.h:
##########
@@ -21,16 +21,18 @@
namespace doris {
namespace BeConsts {
-const std::string CSV = "csv";
-const std::string CSV_WITH_NAMES = "csv_with_names";
-const std::string CSV_WITH_NAMES_AND_TYPES = "csv_with_names_and_types";
-const std::string BLOCK_TEMP_COLUMN_PREFIX = "__TEMP__";
-const std::string ROWID_COL = "__DORIS_ROWID_COL__";
-const std::string ROW_STORE_COL = "__DORIS_ROW_STORE_COL__";
-const std::string DYNAMIC_COLUMN_NAME = "__DORIS_DYNAMIC_COL__";
+
+inline const std::string CSV = "csv";
+inline const std::string CSV_WITH_NAMES = "csv_with_names";
+inline const std::string CSV_WITH_NAMES_AND_TYPES = "csv_with_names_and_types";
+inline const std::string BLOCK_TEMP_COLUMN_PREFIX = "__TEMP__";
+inline const std::string ROWID_COL = "__DORIS_ROWID_COL__";
+inline const std::string ROW_STORE_COL = "__DORIS_ROW_STORE_COL__";
+inline const std::string DYNAMIC_COLUMN_NAME = "__DORIS_DYNAMIC_COL__";
-constexpr int MAX_DECIMAL32_PRECISION = 9;
-constexpr int MAX_DECIMAL64_PRECISION = 18;
-constexpr int MAX_DECIMAL128_PRECISION = 38;
+inline constexpr int MAX_DECIMAL32_PRECISION = 9;
+inline constexpr int MAX_DECIMAL64_PRECISION = 18;
+inline constexpr int MAX_DECIMAL128_PRECISION = 38;
Review Comment:
warning: inline variables are a C++17 extension
[clang-diagnostic-c++17-extensions]
```cpp
inline constexpr int MAX_DECIMAL128_PRECISION = 38;
^
```
##########
be/src/common/consts.h:
##########
@@ -21,16 +21,18 @@
namespace doris {
namespace BeConsts {
-const std::string CSV = "csv";
-const std::string CSV_WITH_NAMES = "csv_with_names";
-const std::string CSV_WITH_NAMES_AND_TYPES = "csv_with_names_and_types";
-const std::string BLOCK_TEMP_COLUMN_PREFIX = "__TEMP__";
-const std::string ROWID_COL = "__DORIS_ROWID_COL__";
-const std::string ROW_STORE_COL = "__DORIS_ROW_STORE_COL__";
-const std::string DYNAMIC_COLUMN_NAME = "__DORIS_DYNAMIC_COL__";
+
+inline const std::string CSV = "csv";
+inline const std::string CSV_WITH_NAMES = "csv_with_names";
+inline const std::string CSV_WITH_NAMES_AND_TYPES = "csv_with_names_and_types";
+inline const std::string BLOCK_TEMP_COLUMN_PREFIX = "__TEMP__";
+inline const std::string ROWID_COL = "__DORIS_ROWID_COL__";
+inline const std::string ROW_STORE_COL = "__DORIS_ROW_STORE_COL__";
+inline const std::string DYNAMIC_COLUMN_NAME = "__DORIS_DYNAMIC_COL__";
Review Comment:
warning: inline variables are a C++17 extension
[clang-diagnostic-c++17-extensions]
```cpp
inline const std::string DYNAMIC_COLUMN_NAME = "__DORIS_DYNAMIC_COL__";
^
```
##########
be/src/common/consts.h:
##########
@@ -21,16 +21,18 @@
namespace doris {
namespace BeConsts {
-const std::string CSV = "csv";
-const std::string CSV_WITH_NAMES = "csv_with_names";
-const std::string CSV_WITH_NAMES_AND_TYPES = "csv_with_names_and_types";
-const std::string BLOCK_TEMP_COLUMN_PREFIX = "__TEMP__";
-const std::string ROWID_COL = "__DORIS_ROWID_COL__";
-const std::string ROW_STORE_COL = "__DORIS_ROW_STORE_COL__";
-const std::string DYNAMIC_COLUMN_NAME = "__DORIS_DYNAMIC_COL__";
+
+inline const std::string CSV = "csv";
+inline const std::string CSV_WITH_NAMES = "csv_with_names";
Review Comment:
warning: inline variables are a C++17 extension
[clang-diagnostic-c++17-extensions]
```cpp
inline const std::string CSV_WITH_NAMES = "csv_with_names";
^
```
##########
be/src/common/consts.h:
##########
@@ -21,16 +21,18 @@
namespace doris {
namespace BeConsts {
-const std::string CSV = "csv";
-const std::string CSV_WITH_NAMES = "csv_with_names";
-const std::string CSV_WITH_NAMES_AND_TYPES = "csv_with_names_and_types";
-const std::string BLOCK_TEMP_COLUMN_PREFIX = "__TEMP__";
-const std::string ROWID_COL = "__DORIS_ROWID_COL__";
-const std::string ROW_STORE_COL = "__DORIS_ROW_STORE_COL__";
-const std::string DYNAMIC_COLUMN_NAME = "__DORIS_DYNAMIC_COL__";
+
+inline const std::string CSV = "csv";
+inline const std::string CSV_WITH_NAMES = "csv_with_names";
+inline const std::string CSV_WITH_NAMES_AND_TYPES = "csv_with_names_and_types";
+inline const std::string BLOCK_TEMP_COLUMN_PREFIX = "__TEMP__";
+inline const std::string ROWID_COL = "__DORIS_ROWID_COL__";
+inline const std::string ROW_STORE_COL = "__DORIS_ROW_STORE_COL__";
Review Comment:
warning: inline variables are a C++17 extension
[clang-diagnostic-c++17-extensions]
```cpp
inline const std::string ROW_STORE_COL = "__DORIS_ROW_STORE_COL__";
^
```
##########
be/src/common/consts.h:
##########
@@ -21,16 +21,18 @@
namespace doris {
namespace BeConsts {
-const std::string CSV = "csv";
-const std::string CSV_WITH_NAMES = "csv_with_names";
-const std::string CSV_WITH_NAMES_AND_TYPES = "csv_with_names_and_types";
-const std::string BLOCK_TEMP_COLUMN_PREFIX = "__TEMP__";
-const std::string ROWID_COL = "__DORIS_ROWID_COL__";
-const std::string ROW_STORE_COL = "__DORIS_ROW_STORE_COL__";
-const std::string DYNAMIC_COLUMN_NAME = "__DORIS_DYNAMIC_COL__";
+
+inline const std::string CSV = "csv";
+inline const std::string CSV_WITH_NAMES = "csv_with_names";
+inline const std::string CSV_WITH_NAMES_AND_TYPES = "csv_with_names_and_types";
+inline const std::string BLOCK_TEMP_COLUMN_PREFIX = "__TEMP__";
+inline const std::string ROWID_COL = "__DORIS_ROWID_COL__";
+inline const std::string ROW_STORE_COL = "__DORIS_ROW_STORE_COL__";
+inline const std::string DYNAMIC_COLUMN_NAME = "__DORIS_DYNAMIC_COL__";
-constexpr int MAX_DECIMAL32_PRECISION = 9;
-constexpr int MAX_DECIMAL64_PRECISION = 18;
-constexpr int MAX_DECIMAL128_PRECISION = 38;
+inline constexpr int MAX_DECIMAL32_PRECISION = 9;
+inline constexpr int MAX_DECIMAL64_PRECISION = 18;
Review Comment:
warning: inline variables are a C++17 extension
[clang-diagnostic-c++17-extensions]
```cpp
inline constexpr int MAX_DECIMAL64_PRECISION = 18;
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
