yiguolei commented on code in PR #19251:
URL: https://github.com/apache/doris/pull/19251#discussion_r1185627477
##########
be/src/olap/push_handler.cpp:
##########
@@ -239,13 +239,6 @@ Status PushHandler::_convert_v2(TabletSharedPtr
cur_tablet, RowsetSharedPtr* cur
}
// For push load, this tablet maybe not need push data, so that the
path maybe empty
if (!path.empty()) {
- std::unique_ptr<PushBrokerReader> reader(new (std::nothrow)
PushBrokerReader());
- if (reader == nullptr) {
- LOG(WARNING) << "fail to create reader. tablet=" <<
cur_tablet->full_name();
- res = Status::Error<MEM_ALLOC_FAILED>();
- break;
- }
-
// init schema
std::unique_ptr<Schema> schema(new (std::nothrow)
Schema(tablet_schema));
Review Comment:
The variable schema is useless, just remove it and remove the parameter from
PushBrokerReader's constructor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
