[GitHub] [doris] morningman commented on a diff in pull request #19098: [refactor](fs)(step3)use filesystem instead of old storage, new storage just access remote object storage

[via GitHub]

morningman commented on code in PR #19098:
URL: https://github.com/apache/doris/pull/19098#discussion_r1178555584


##########
fe/fe-core/src/main/java/org/apache/doris/catalog/HiveMetaStoreClientHelper.java:
##########
@@ -212,7 +213,7 @@ public static String normalizeS3LikeSchema(String location) 
{
     }
 
     private static String getAllFileStatus(List<TBrokerFileStatus> 
fileStatuses,
-            List<RemoteIterator<LocatedFileStatus>> remoteIterators, 
BlobStorage storage) throws UserException {
+            List<RemoteIterator<LocatedFileStatus>> remoteIterators, 
RemoteFileSystem storage) throws UserException {

Review Comment:
   ```suggestion
               List<RemoteIterator<LocatedFileStatus>> remoteIterators, 
RemoteFileSystem fs) throws UserException {
   ```



##########
fe/fe-core/src/main/java/org/apache/doris/fs/LocalFileSystem.java:
##########
@@ -62,4 +63,9 @@ public Status makeDir(String remotePath) {
     public Status list(String remotePath, List<RemoteFile> result, boolean 
fileNameOnly) {
         return null;
     }
+
+    @Override
+    public Map<String, String> getProperties() {
+        return null;

Review Comment:
   Avoid return null.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org