vagetablechicken opened a new pull request #3286: unregister fragment mem tracker in close() URL: https://github.com/apache/incubator-doris/pull/3286 ref https://github.com/apache/incubator-doris/issues/3273 P.S. https://github.com/apache/incubator-doris/blob/614a76beeac73821c78903c46e7a703b7956796b/be/src/runtime/plan_fragment_executor.cpp#L559-L562 I think this piece of code is useless. This `_mem_tracker` in `PlanFragmentExecutor` is set as fragment_mem_tracker of `RuntimeState`. **direct use** We use it in these code, when rowbatch reset, mem tracker's consumption will be released. https://github.com/apache/incubator-doris/blob/7eab12a40e5a20959c13eba99697c171d1461e0b/be/src/exec/olap_rewrite_node.cpp#L57-L58 https://github.com/apache/incubator-doris/blob/839ec45197fb4559c4946bf0fa4ce3b6805b4248/be/src/exec/olap_scan_node.cpp#L1217-L1218 **other usage** e.g. https://github.com/apache/incubator-doris/blob/6c33f805449d9a7bc8809a575407acfa87bb061e/be/src/exec/olap_scanner.cpp#L245 won't consume the fragment mem tracker. We don't need to worry about the fragment mem tracker consumption is not zero when we want to destroy it. Or we can add a consumption check before we close the mem tracker?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
