wuyunfeng commented on a change in pull request #3186: Support convert Arrow
data to RowBatch asynchronously in Spark-Doris-Connector
URL: https://github.com/apache/incubator-doris/pull/3186#discussion_r397206105
##########
File path:
extension/spark-doris-connector/src/main/java/org/apache/doris/spark/serialization/RowBatch.java
##########
@@ -70,7 +70,8 @@ public void put(Object o) {
}
}
- private int offsetInOneBatch = 0;
+ // offset for iterate the rowBatch
+ private int offsetInRowBatch = 0;
private int rowCountInOneBatch = 0;
private int readRowCount = 0;
private List<Row> rowBatch = new ArrayList<>();
Review comment:
whether we can use a fixed array which size = rowCount or batch_size with a
size flag?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
