imay commented on a change in pull request #3069: Support 64 bit timestamp in
from_unixtime
URL: https://github.com/apache/incubator-doris/pull/3069#discussion_r390703554
##########
File path: be/src/runtime/datetime_value.cpp
##########
@@ -1557,13 +1557,28 @@ bool DateTimeValue::from_unixtime(int64_t timestamp,
const std::string& timezone
if (timestamp < 0 || timestamp > 253402271999L) {
return false;
}
+
boost::local_time::time_zone_ptr local_time_zone =
TimezoneDatabase::find_timezone(timezone);
if (local_time_zone == nullptr) {
return false;
}
- boost::local_time::local_date_time
lt(boost::posix_time::from_time_t(timestamp), local_time_zone);
+
+ int64_t current_t = timestamp;
+ boost::posix_time::ptime time =
boost::posix_time::ptime(boost::gregorian::date(1970,1,1));
+
+ while(current_t > 0) {
Review comment:
```suggestion
while (current_t > 0) {
```
Add some comments about what this block is doing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
