morningman commented on a change in pull request #2979: Incomplete support
Array type (#2871)
URL: https://github.com/apache/incubator-doris/pull/2979#discussion_r386750847
##########
File path: be/src/util/mysql_row_buffer.cpp
##########
@@ -67,6 +71,25 @@ MysqlRowBuffer::~MysqlRowBuffer() {
}
}
+void MysqlRowBuffer::open_dynamic_mode() {
+ if (_dynamic_mode == 0) {
+ *_pos++ = 254;
+ // write length when dynamic mode close
+ _len_pos = _pos;
+ _pos = _pos + 8;
+ }
+ _dynamic_mode++;
+}
+
+void MysqlRowBuffer::close_dynamic_mode() {
+ _dynamic_mode--;
+
+ if (_dynamic_mode == 0) {
Review comment:
```suggestion
if (NOT_DYNAMIC_MODE) {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
