morningman commented on a change in pull request #2979: Incomplete support
Array type (#2871)
URL: https://github.com/apache/incubator-doris/pull/2979#discussion_r386461175
##########
File path: fe/src/main/java/org/apache/doris/analysis/TypeDef.java
##########
@@ -67,6 +69,20 @@ private void analyze(Type type) throws AnalysisException {
if (!type.isSupported()) {
throw new AnalysisException("Unsupported data type: " + type.toSql());
}
+
+ if (type.isArrayType()) {
+ if (FeMetaVersion.VERSION_CURRENT < FeMetaVersion.VERSION_74) {
+ throw new AnalysisException("Unsupported data type: " + type.toSql());
+ }
+
+ Type itemType = ((ArrayType) type).getItemType();
+ if (itemType.isNull()) {
Review comment:
I see that you just support INT 和 VARCHAR as the item type of array? Why
just checking null here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
