chaoyli commented on a change in pull request #3000: use canonical path in 
DiskInfo::get_disk_devices()
URL: https://github.com/apache/incubator-doris/pull/3000#discussion_r384433435
 
 

 ##########
 File path: be/src/util/disk_info.cpp
 ##########
 @@ -158,33 +159,40 @@ std::string DiskInfo::debug_string() {
 
 Status DiskInfo::get_disk_devices(const std::vector<std::string>& paths,
                                   std::set<std::string>* devices) {
+    std::vector<std::string> abs_paths;
 
 Review comment:
   real_paths may be a better name 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to