kangkaisen commented on a change in pull request #2847: Doris support in memory
olap table
URL: https://github.com/apache/incubator-doris/pull/2847#discussion_r377440342
##########
File path: fe/src/main/java/org/apache/doris/alter/SchemaChangeHandler.java
##########
@@ -1405,6 +1420,88 @@ private void sendClearAlterTask(Database db, OlapTable
olapTable) {
LOG.info("send clear alter task for table {}, number: {}",
olapTable.getName(), batchTask.getTaskNum());
}
+ public void sendUpdateTabletMetaInfoTask(Database db, OlapTable olapTable,
boolean isInMemory) throws DdlException {
+ List<Partition> partitions = Lists.newArrayList();
+ db.readLock();
+ try {
+ partitions.addAll(olapTable.getPartitions());
+ } finally {
+ db.readUnlock();
+ }
+ for(Partition partition: partitions) {
+ sendUpdateTabletMetaTaskForPartition(db, olapTable, partition,
isInMemory);
+ }
+ }
+
+ public void sendUpdateTabletMetaTaskForPartition(Database db,
Review comment:
If partial success, we will return error to user, and the error msg warn
user to retry.
Because this operation is idempotent，So retry is OK.
If we want to avoid partial success, we need to support tablet meta rollback
operation. I think which is complex and unnecessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
