morningman commented on a change in pull request #2748: [Snapshot] Modify the
prefer snapshot version
URL: https://github.com/apache/incubator-doris/pull/2748#discussion_r366158884
##########
File path: gensrc/thrift/AgentService.thrift
##########
@@ -178,7 +178,7 @@ struct TSnapshotRequest {
7: optional bool list_files
// if all nodes has been upgraded, it can be removed.
8: optional bool allow_incremental_clone
- 9: optional i32 preferred_snapshot_version = 1 // request preferred
snapshot version, default value is 1 for old version be
+ 9: optional i32 preferred_snapshot_version =
Types.TPREFER_SNAPSHOT_REQ_VERSION
Review comment:
No problem, the version 1 is no longer used, and if we set it to 1, snapshot
will failed.
Actually, preferred_snapshot_version is a `required` field, and should
always be set to
`TPREFER_SNAPSHOT_REQ_VERSION`. Make it as `optional` is just for
compatibility.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
