morningman commented on a change in pull request #2704: Remove resource_info
related members from TaskWorkerPool
URL: https://github.com/apache/incubator-doris/pull/2704#discussion_r365277911
##########
File path: be/src/agent/task_worker_pool.cpp
##########
@@ -826,46 +714,41 @@ void*
TaskWorkerPool::_publish_version_worker_thread_callback(void* arg_this) {
break;
} else {
OLAP_LOG_WARNING("publish version error, retry. "
- "[transaction_id=%ld, error_tablet_size=%d]",
+ "[transaction_id=%ld, error_tablets_size=%d]",
publish_version_req.transaction_id,
error_tablet_ids.size());
- retry_time += 1;
- sleep(1);
+ ++retry_time;
+ SleepForMs(1000);
}
}
TFinishTaskRequest finish_task_request;
if (res != OLAP_SUCCESS) {
- // if publish failed, return failed, fe will ignore this error and
- // check error tablet ids and fe will also republish this task
- status_code = TStatusCode::RUNTIME_ERROR;
+ DorisMetrics::publish_task_failed_total.increment(1);
+ // if publish failed, return failed, FE will ignore this error and
+ // check error tablet ids and FE will also republish this task
LOG(WARNING) << "publish version failed. signature:" <<
agent_task_req.signature;
Review comment:
better to print `res` here, and also put the `res` in the following
`Status::RuntimeError()`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
