imay commented on a change in pull request #2630: Support bitmap index for more 
type
URL: https://github.com/apache/incubator-doris/pull/2630#discussion_r365110875
 
 

 ##########
 File path: be/src/util/coding.h
 ##########
 @@ -51,6 +53,15 @@ inline void encode_fixed64_le(uint8_t* buf, uint64_t val) {
 #endif
 }
 
+inline void encode_fixed128_le(uint8_t* buf, uint128_t val) {
+    #if __BYTE_ORDER == __LITTLE_ENDIAN
 
 Review comment:
   ```suggestion
   #if __BYTE_ORDER == __LITTLE_ENDIAN
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to