HangyuanLiu commented on a change in pull request #2725: Add
timestampadd/timestampdiff function
URL: https://github.com/apache/incubator-doris/pull/2725#discussion_r365065304
##########
File path: be/src/exprs/timestamp_functions.cpp
##########
@@ -351,6 +351,92 @@ DateTimeVal TimestampFunctions::timestamp_time_op(
return new_ts_val;
}
+BigIntVal TimestampFunctions::years_diff(
+ FunctionContext* ctx, const DateTimeVal& ts_val1, const DateTimeVal&
ts_val2) {
+ return timestamp_diff<YEAR>(ctx, ts_val1, ts_val2);
+}
+
+BigIntVal TimestampFunctions::months_diff(
+ FunctionContext* ctx, const DateTimeVal& ts_val1, const DateTimeVal&
ts_val2) {
+ return timestamp_diff<MONTH>(ctx, ts_val1, ts_val2);
+}
+
+BigIntVal TimestampFunctions::weeks_diff(
+ FunctionContext* ctx, const DateTimeVal& ts_val1, const DateTimeVal&
ts_val2) {
+ return timestamp_diff<WEEK>(ctx, ts_val1, ts_val2);
+}
+
+BigIntVal TimestampFunctions::days_diff(
+ FunctionContext* ctx, const DateTimeVal& ts_val1, const DateTimeVal&
ts_val2) {
+ return timestamp_diff<DAY>(ctx, ts_val1, ts_val2);
+}
+
+BigIntVal TimestampFunctions::hours_diff(
+ FunctionContext* ctx, const DateTimeVal& ts_val1, const DateTimeVal&
ts_val2) {
+ return timestamp_diff<HOUR>(ctx, ts_val1, ts_val2);
+}
+
+BigIntVal TimestampFunctions::minutes_diff(
+ FunctionContext* ctx, const DateTimeVal& ts_val1, const DateTimeVal&
ts_val2) {
+ return timestamp_diff<MINUTE>(ctx, ts_val1, ts_val2);
+}
+
+BigIntVal TimestampFunctions::seconds_diff(
+ FunctionContext* ctx, const DateTimeVal& ts_val1, const DateTimeVal&
ts_val2) {
+ return timestamp_diff<SECOND>(ctx, ts_val1, ts_val2);
+}
+
+template <TimeUnit unit>
+BigIntVal TimestampFunctions::timestamp_diff(FunctionContext* ctx, const
DateTimeVal& ts_val2, const DateTimeVal& ts_val1) {
+ std::cout << "null" << std::endl;
Review comment:
Sorry, I forget
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
