yangzhg commented on a change in pull request #2710: use cgroups memory limit and cpu cores in container URL: https://github.com/apache/incubator-doris/pull/2710#discussion_r364581437
########## File path: be/src/util/cgroup_util.cpp ########## @@ -0,0 +1,229 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include "util/cgroup_util.h" + +#include <algorithm> +#include <fstream> +#include <iostream> +#include <utility> + +#include "gutil/strings/escaping.h" +#include "gutil/strings/substitute.h" +#include "gutil/strings/split.h" +#include "util/error_util.h" +#include "util/file_utils.h" +#include "util/string_parser.hpp" + +#include "common/names.h" + +using strings::CUnescape; +using strings::Split; +using strings::SkipWhitespace; +using std::pair; + +namespace doris { + +Status CGroupUtil::find_global_cgroup(const string& subsystem, string* path) { + ifstream proc_cgroups("/proc/self/cgroup", ios::in); + string line; + while (true) { + if (proc_cgroups.fail()) { + return Status::IOError(Substitute("Error reading /proc/self/cgroup: $0", get_str_err_msg())); + } else if (proc_cgroups.peek() == std::ifstream::traits_type::eof()) { + return Status::NotFound(Substitute("Could not find subsystem $0 in /proc/self/cgroup", subsystem)); + } + // The line format looks like this: + // 4:memory:/user.slice + // 9:cpu,cpuacct:/user.slice + // so field size will be 3 + getline(proc_cgroups, line); + if (!proc_cgroups.good()) { + continue; + } + vector<string> fields = Split(line, ":"); + DCHECK_GE(fields.size(), 3); + // ":" in the path does not appear to be escaped - bail in the unusual case that + // we get too many tokens. + if (fields.size() != 3) { + return Status::InvalidArgument(Substitute( + "Could not parse line from /proc/self/cgroup - had $0 > 3 tokens: '$1'", + fields.size(), line)); + } + vector<string> subsystems = Split(fields[1], ","); + auto it = std::find(subsystems.begin(), subsystems.end(), subsystem); + if (it != subsystems.end()) { + *path = move(fields[2]); + return Status::OK(); + } + } +} + +static Status unescape_path(const string& escaped, string* unescaped) { + string err; + if (!CUnescape(escaped, unescaped, &err)) { + return Status::InvalidArgument(Substitute("Could not unescape path '$0': $1", escaped, err)); + } + return Status::OK(); +} + +static Status read_cgroup_value(const string& limit_file_path, int64_t* val) { + ifstream limit_file(limit_file_path, ios::in); + string line; + getline(limit_file, line); + if (limit_file.fail() || limit_file.bad()) { + return Status::IOError(Substitute("Error reading $0: $1", limit_file_path, get_str_err_msg())); + } + StringParser::ParseResult pr; + // Parse into an an int64_t If it overflows, returning the max value of int64_t is ok because that + // is effectively unlimited. + *val = StringParser::string_to_int<int64_t>(line.c_str(), line.size(), &pr); + if ((pr != StringParser::PARSE_SUCCESS && pr != StringParser::PARSE_OVERFLOW)) { + return Status::InvalidArgument( + Substitute("Failed to parse $0 as int64: '$1'", limit_file_path, line)); + } + return Status::OK(); +} + +Status CGroupUtil::find_cgroup_mounts( + const string& subsystem, pair<string, string>* result) { + ifstream mountinfo("/proc/self/mountinfo", ios::in); Review comment: this is done automatically by the ifstream destructor. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
