imay commented on a change in pull request #2632: [Rowset Reader] Improve the
merge read efficiency of alpha rowsets
URL: https://github.com/apache/incubator-doris/pull/2632#discussion_r362320010
##########
File path: be/src/olap/rowset/alpha_rowset_reader.h
##########
@@ -103,6 +128,9 @@ class AlphaRowsetReader : public RowsetReader {
RowsetReaderContext* _current_read_context;
OlapReaderStatistics _owned_stats;
OlapReaderStatistics* _stats = &_owned_stats;
+
+ // a priority queue for merging rowsets
+ std::priority_queue<RowCursorWithOrdinal, vector<RowCursorWithOrdinal>,
RowCursorWithOrdinalComparator> _merge_queue;
Review comment:
why not use use **RowCursorWithOrdinal** as element of queue. If then, there
is no need to record ordinal.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
